Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AM status from title #5261

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

Konstantinov-Innokentii
Copy link
Member

No description provided.

@Konstantinov-Innokentii Konstantinov-Innokentii requested a review from a team as a code owner November 17, 2024 05:51
@Konstantinov-Innokentii Konstantinov-Innokentii added release:patch PR will be added to "Other Changes" section of release notes pr:no public docs Added to a PR that does not require public documentation updates labels Nov 21, 2024
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for those of us less familiar with alertmanager, can you give some context as to why we want to remove the status from the title (by default)?

@Konstantinov-Innokentii
Copy link
Member Author

Konstantinov-Innokentii commented Nov 21, 2024

for those of us less familiar with alertmanager, can you give some context as to why we want to remove the status from the title (by default)?

So, that was bothering me & @raphael-batte for a long time. Having [Firing:X]<Alertname> in the title just makes it cumbersome & makes Incident titles weird when they are declared from alerts, since alert group title is becoming an Incident title. This amount of firing alerts is anyway rendered in the message part of the AlertGroup.

@Konstantinov-Innokentii Konstantinov-Innokentii added this pull request to the merge queue Nov 22, 2024
Merged via the queue into dev with commit 1b4cca9 Nov 22, 2024
46 of 47 checks passed
@Konstantinov-Innokentii Konstantinov-Innokentii deleted the remove_am_status_from_title branch November 22, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants